RFR: 8296157: Rename FileMapInfo::space_at() to region_at() [v3]

Calvin Cheung ccheung at openjdk.org
Thu Nov 3 18:34:41 UTC 2022


On Wed, 2 Nov 2022 16:54:27 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Most of the CDS code refers to a memory blocks inside a CDS file as "regions", represented by the type FileMapRegion. The method FileRegion* space_at() has been renamed to region_at() and all instances of its use have been replaced. Verified with tier 1-4 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed code alignment

Looks good.

One nit: please update copyright year 2021 to 2022 in cdsConstants.cpp.

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10937


More information about the hotspot-runtime-dev mailing list