RFR: JDK-8295865: Several issues with os::realloc [v2]
David Holmes
dholmes at openjdk.org
Fri Nov 4 06:05:27 UTC 2022
On Mon, 31 Oct 2022 09:40:43 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - add clarifying comment about ASSERT/EXPECT helpers
>> - if realloc(3) fails, revive the old header and re-account its size with NMT
>
> This all appears to be quite reasonable.
>
> I have a couple of queries.
>
> Thanks.
> @dholmes-ora what do you think? Should I revert to the earlier, simpler version?
Sorry @tstuefe I don't know enough about NMT to evaluate the two versions.
-------------
PR: https://git.openjdk.org/jdk/pull/10857
More information about the hotspot-runtime-dev
mailing list