RFR: 8295099: vmTestbase/nsk/stress/strace/strace013.java failed with "TestFailure: wrong lengths of stack traces: strace013Thread0: NNN strace013Thread83: MMM" [v2]
David Holmes
dholmes at openjdk.org
Mon Nov 7 22:41:31 UTC 2022
> The test is incorrectly synchronized and may take the stack trace of a thread before it has entered the wait() and thus be three frames short of the correct stack. So I cleaned that up to ensure things are correctly synchronized.
>
> A number of comments in the test description etc were wrong so I also fixed those.
>
> These tests are stylistically awful but I refrained from embarking on a major cleanup and adopted the prevailing styles.
>
> Testing: local plus 50x on each platform (in progress)
>
> Thanks.
David Holmes has updated the pull request incrementally with one additional commit since the last revision:
Fix comment typos.
Remove "k-2" slack now that we are more precise.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/11011/files
- new: https://git.openjdk.org/jdk/pull/11011/files/e0a1acdc..fc1378fa
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=11011&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=11011&range=00-01
Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/11011.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/11011/head:pull/11011
PR: https://git.openjdk.org/jdk/pull/11011
More information about the hotspot-runtime-dev
mailing list