RFR: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection

Johan Sjölen jsjolen at openjdk.org
Tue Nov 8 14:57:26 UTC 2022


On Tue, 4 Oct 2022 11:44:26 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> This is only a refactoring where the usage of manual character buffers are replaced with output streams, leading to much simpler code.

Re: Why this code uses C-strings.

The commit that introduces "raw" string handling for logOutput.cpp regarding these changes is from Marcus Larsson. I doubt that we'll hear from him :-). The only reviewer (from mailing list thread) of that commit that I know still works on the JDK is @dholmes-ora. The review comments were literally: "Looks good".

-------------

PR: https://git.openjdk.org/jdk/pull/10553


More information about the hotspot-runtime-dev mailing list