RFR: 8295099: vmTestbase/nsk/stress/strace/strace013.java failed with "TestFailure: wrong lengths of stack traces: strace013Thread0: NNN strace013Thread83: MMM" [v3]
David Holmes
dholmes at openjdk.org
Thu Nov 10 07:35:08 UTC 2022
On Thu, 10 Nov 2022 07:25:14 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> The test is incorrectly synchronized and may take the stack trace of a thread before it has entered the wait() and thus be three frames short of the correct stack. So I cleaned that up to ensure things are correctly synchronized.
>>
>> A number of comments in the test description etc were wrong so I also fixed those.
>>
>> These tests are stylistically awful but I refrained from embarking on a major cleanup and adopted the prevailing styles.
>>
>> Testing: local plus 50x on each platform (in progress)
>>
>> Thanks.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>
> Revert sophisticated fix and just correct the "slack" allownace from 2 to 3.
The "request re-review" functionality seems to be broken :(
-------------
PR: https://git.openjdk.org/jdk/pull/11011
More information about the hotspot-runtime-dev
mailing list