RFR: 8296453: Simplify resource_area uses in ClassPathDirEntry::open_stream [v3]

[David Holmes]

On Fri, 11 Nov 2022 06:53:01 GMT, Xin Liu <xliu at openjdk.org> wrote:

>> Currently it is correct, but there are two places we can improve it.
>> 
>> 1. We should assert that current == Thread::current(). If it were not case, then we would intermix NEW_RESOURCE_ARRAY_IN_THREAD(current, char, path_len) and FREE_RESOURCE_ARRAY(char, path, path_len)!
>> 
>> 2. We don't need to call FREE_RESOURCE_ARRAY(char, path, path_len) for path in its first exit. It won't release anything because buffer stands in its way.
>> 
>> The resource area is like this. `Afree(path, path_len)` won't reclaim the space.
>> 
>> |path | buffer |...|
>>                ^hwm
>
> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update it per reviewer's feedback.

Marked as reviewed by dholmes (Reviewer).

-------------

PR: https://git.openjdk.org/jdk/pull/11024