RFR: 8296155: Simplify CDS heap region address calculation [v5]

Ioi Lam iklam at openjdk.org
Wed Nov 16 19:36:27 UTC 2022


> Rewrite and simplify the convoluted logic used to calculate the runtime location of a CDS heap region. Now it's as simple as:
> 
> 
> FileMapRegion::dumptime_base() + ArchiveHeapLoader::runtime_delta();
> 
> 
> See `FileMapInfo::heap_region_runtime_start_address` for an example.
> 
> Also removed dead code:
> 
> - `FileMapInfo::is_in_shared_region`
> - `MetaspaceShared::is_in_shared_region`
> - `FileMapInfo::stop_sharing_and_unmap`

Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:

  fixed comments

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10923/files
  - new: https://git.openjdk.org/jdk/pull/10923/files/7586d396..31ecc075

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10923&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10923&range=03-04

  Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/10923.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10923/head:pull/10923

PR: https://git.openjdk.org/jdk/pull/10923


More information about the hotspot-runtime-dev mailing list