RFR: 8296754: AutoCreateSharedArchive in JDK 20 is not compatible with JDK 19 [v3]

[Ioi Lam]

On Wed, 16 Nov 2022 22:30:56 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> The -XX:+AutoCreateSharedArchive flag was implemented in JDK 19, however, this flag doesn't work across JDK 19 and 20.
>> 
>> Expected: JDK 20 should recreate the specified CDS archive
>> Actual: JDK 20 cannot recognize the archive file and gives up
>> 
>> The new field from GenericCDSFileMapHeader is now in FileMapHeader. Verified with tier 1-4 tests.
>
> Matias Saavedra Silva has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Test now passes

LGTM. Some minor nits for the test.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 40:

> 38: import jdk.test.lib.process.OutputAnalyzer;
> 39: import jdk.test.lib.process.ProcessTools;
> 40: import jtreg.SkippedException;

This import is no longer necessary.

test/hotspot/jtreg/runtime/cds/appcds/dynamicArchive/TestAutoCreateSharedArchiveUpgrade.java line 145:

> 143:         output.shouldContain("Mapped dynamic region #0");
> 144:     }
> 145: }

Need a newline at the end of the file.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11148