RFR: JDK-8297184: Test runtime/ErrorHandling/TestSigInfoInHsErrFile.java is failing

[David Holmes]

On Thu, 17 Nov 2022 08:21:43 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> https://bugs.openjdk.org/browse/JDK-8296906 added a new test that artificially crashes the VM with a known signal/code/crashaddress and checks that we see those informations precisely in the hs-err file. It did this for SIGSEGV and SIGFPE.
> 
> SIGFPE, however, is problematic. We fall back to pthread_kill() if we cannot trigger a real FPE fault. In that case the code will be SI_KILL and the sending frame will be pthread_kill(). 
> 
> Since we cannot guarantee that a real signal is sent, I opted for just removing the part of the test that tests FPE. The other part, testing SIGSEGV, is enough to cover what the test should cover.

I thought you might just drop the `#` from the match pattern, but removing the SIGFPE case seems okay too.

One typo below.

Thanks.

test/hotspot/jtreg/runtime/ErrorHandling/TestSigInfoInHsErrFile.java line 70:

> 68:     patterns.add(Pattern.compile("# .*VMError::controlled_crash.*"));
> 69: 
> 70:     // Crash address: see VMError::_segfault_address - carefully choosen to give us a SEGV_MAPERR

s/choosen/chosen/

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11202