RFR: JDK-8297184: Test runtime/ErrorHandling/TestSigInfoInHsErrFile.java is failing [v3]

Thomas Stuefe stuefe at openjdk.org
Thu Nov 17 13:14:04 UTC 2022


> https://bugs.openjdk.org/browse/JDK-8296906 added a new test that artificially crashes the VM with a known signal/code/crashaddress and checks that we see those informations precisely in the hs-err file. It did this for SIGSEGV and SIGFPE.
> 
> SIGFPE, however, is problematic. We fall back to pthread_kill() if we cannot trigger a real FPE fault. In that case the code will be SI_KILL and the sending frame will be pthread_kill(). 
> 
> Since we cannot guarantee that a real signal is sent, I opted for just removing the part of the test that tests FPE. The other part, testing SIGSEGV, is enough to cover what the test should cover.

Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:

  removed carefully chosen comment since appearantly it was not careful enough :(

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/11202/files
  - new: https://git.openjdk.org/jdk/pull/11202/files/afbe951c..31df8678

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=11202&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=11202&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/11202.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/11202/head:pull/11202

PR: https://git.openjdk.org/jdk/pull/11202


More information about the hotspot-runtime-dev mailing list