RFR: JDK-8296784: Provide clean mallinfo/mallinfo2 wrapper for Linux glibc platforms [v2]

Thomas Stuefe stuefe at openjdk.org
Sat Nov 19 07:21:28 UTC 2022


On Sat, 19 Nov 2022 06:40:51 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> This is a breakout from [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved for reviews. So I attempt to break up that fix into smaller units which are hopefully easier to review separately.
>> 
>> We use the glibc-specific mallinfo/mallinfo2 APIs to query libc internals. These are quite important, since they are the only way to get the malloc load and retained size from the glibc allocator. NMT only reports a tiny part of that (only the user-view of whatever hotspot allocated).
>> 
>> Using these APIs and staying glibc-agnostic requires some twiddling. This patch provides a clean wrapper to hide that twiddling from the end caller.
>> 
>> Patch also fixes a display error that may have caused omission of the "may have wrapped" marker in the hs-err printout of the malloc load.
>> 
>> Also, gtest regression test.
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Feedback roman, martin

Manually tested fastdebug on Alpine and on 32-bit, and merged master. I'll wait for GHAs to complete, then push.

Thanks @dholmes-ora @rkennke @MBaesken for reviewing!

-------------

PR: https://git.openjdk.org/jdk/pull/11088


More information about the hotspot-runtime-dev mailing list