RFR: JDK-8296764 NMT: reduce loads in os::malloc [v2]

[Ioi Lam]

On Fri, 11 Nov 2022 06:10:20 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> We read the NMT level at every ps::malloc/realloc/free etc, even if NMT is off. That is unavoidable. But we also read a second variable that shadows the NMT level `_nmt_was_initialized`. That state is synonymous with NMT level "unknown," so there is no need for this second load.
>> 
>> Furthermore, NMT level is volatile. That had been necessary in older times since we used to shut down NMT on resource exhaustion. But since [JDK-8256844](https://bugs.openjdk.org/browse/JDK-8256844), NMT level is fixed at initialization, so we can remove the volatile specifier.
>> 
>> Patch 
>> - removes `_nmt_was_initialized` and redirects it to `MemTracker::is_initialized()`, which gets inlined to a load of NMT level. 
>> - makes NMT level non-volatile
>> - removes _is_nmt_env_valid, which had been dead code
>
> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Feedback andrew, ioi

All good. Sorry for the delay.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11080