RFR: 8291067: macOS should use O_CLOEXEC instead of FD_CLOEXEC [v7]
Gerard Ziemski
gziemski at openjdk.org
Mon Nov 21 19:42:34 UTC 2022
On Mon, 21 Nov 2022 19:31:14 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> O_CLOEXEC is also available on macOS (__DARWIN_C_LEVEL >= 200809L), so use it same as on linux.
>
> Gerard Ziemski has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
>
> - Merge master
> - rename test file to test_file.txt, so it's easy to determine the purpose of the artifact to however happens to be looking
> - use open() to create the test file as needed
> - create our own test file, to guarantee it will exist
> - remove comment, fix spacing
> - test on all platforms except Windows
> - add test to verify that open(O_CLOEXEC) implies FD_CLOEXEC on macOS
> - assume O_CLOEXEC on macOS
> - match existing code
> - add missing code from merge
> - ... and 1 more: https://git.openjdk.org/jdk/compare/cd6a203a...db9d11a3
The fix had merge conflict, which I had to cleanup and now everyone who reviewed it is shown as "reviewer of previous version". Am I fine to go ahead with the integration, or do I need your final OK?
-------------
PR: https://git.openjdk.org/jdk/pull/9663
More information about the hotspot-runtime-dev
mailing list