RFR: 8297168: Provide a bulk OopHandle release mechanism with the ServiceThread [v2]
David Holmes
dholmes at openjdk.org
Mon Nov 21 21:27:21 UTC 2022
On Mon, 21 Nov 2022 16:19:32 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Rehn comments
>
> I'm still not happy that ServiceThread knows all about JavaThread's fields that need to be cleared. But all of the OopHandleList code that's in serviceThread.cpp should be moved to javaThread.cpp. And two new functions added to JavaThread for ServiceThread to call (has_oop_handles_to_release and release_oop_handles).
> I still think it's better since JavaThread is the only thing that has the necessity of deferred release.
Thanks for looking at this @coleenp. As I said I didn't think ServiceThread knowing the details was an issue because ServiceThread is-a JavaThread. But sure I can move everything to JavaThread instead if that is preferable.
-------------
PR: https://git.openjdk.org/jdk/pull/11254
More information about the hotspot-runtime-dev
mailing list