RFR: 8297168: Provide a bulk OopHandle release mechanism with the ServiceThread [v3]
David Holmes
dholmes at openjdk.org
Tue Nov 22 02:45:21 UTC 2022
On Mon, 21 Nov 2022 23:16:43 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Move all the code to JavaThread - as requested by @coleenp.
>
> Looks good! Thank you.
Thanks for the review @coleenp !
> src/hotspot/share/runtime/javaThread.hpp line 85:
>
>> 83: friend class Continuation;
>> 84: friend class Threads;
>> 85: friend class ServiceThread; // for deferred OopHandle release access
>
> Does this still have to be a friend? You could make the two functions that ServiceThread calls public.
I made them private and kept ServiceThread a friend so that it was more clear that this is a private interface with the ServiceThread and not some public API that might be called from other code.
-------------
PR: https://git.openjdk.org/jdk/pull/11254
More information about the hotspot-runtime-dev
mailing list