RFR: 8297290: Use int indices to reference CDS archived primitive mirrors [v4]

Ioi Lam iklam at openjdk.org
Wed Nov 23 00:24:24 UTC 2022


On Tue, 22 Nov 2022 00:01:58 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @ashu-mehra comments: rename *_mirror* to *basic_type_mirror*
>
> src/hotspot/share/memory/universe.cpp line 238:
> 
>> 236: 
>> 237: #if INCLUDE_CDS_JAVA_HEAP
>> 238: void Universe::set_archived_mirror_index(BasicType t, int index) {
> 
> Is it called during dump time only?
> If so, maybe add an assert?
> `assert(DumpSharedSpaces, "dump-time only");`

Fixed as suggested.

-------------

PR: https://git.openjdk.org/jdk/pull/11256


More information about the hotspot-runtime-dev mailing list