RFR: 8291418: adjust monitor deflation logging and deflate_idle_monitors use

Thomas Stuefe stuefe at openjdk.org
Wed Nov 23 07:07:22 UTC 2022


On Tue, 22 Nov 2022 17:10:56 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

> Trivial fixes to monitor deflation logging and deflate_idle_monitors use.

Looks good.

But this felt not trivial to me :) I tried to understand the preexisting code:

`while (ObjectSynchronizer::deflate_idle_monitors(tablep) >= (size_t)MonitorDeflationMax) {`

So, was the intent behind this "as long as deflate_idle_monitors() uses its full allotment of deflations, continue, but if you notice it slacking off, stop?" And the assumption is we always deflate n*MonitorDeflationMax + a smaller rest? And this assumption was wrong?

-------------

Marked as reviewed by stuefe (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11293


More information about the hotspot-runtime-dev mailing list