RFR: 8297534: Specify the size of MEMFLAGS [v2]
Thomas Stuefe
stuefe at openjdk.org
Fri Nov 25 06:23:22 UTC 2022
On Thu, 24 Nov 2022 21:21:13 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
> > Hmm, I can live with that, though I would have preferred the raw type for clarity. After all, enum should follow the layout of the header, not the other way around.
> > Can you at least add a static assert that sizeof memflags is 8 bits?
>
> Absolutely. Would you like that right after the definition of MEMFLAGS then? (and not after the definition of `MEMFLAGS _flags` in the header)
I don't care much as long as it explodes when MEMFLAGS are changed :-) If you add it to the hpp file, you need to give it debug.hpp too. I leave it up to you.
-------------
PR: https://git.openjdk.org/jdk/pull/11336
More information about the hotspot-runtime-dev
mailing list