RFR: JDK-8297408: Consolidate code in runtime/ErrorHandling [v2]
Thomas Stuefe
stuefe at openjdk.org
Fri Nov 25 17:52:06 UTC 2022
On Fri, 25 Nov 2022 07:57:48 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Feedback David
>
> Looks good to me, minor points
> test/hotspot/jtreg/runtime/ErrorHandling/HsErrFileUtils.java
>
> "existence of a set of pattern" shouldn't this be
> "existence of a set of patterns" ?
>
> please check COPYRIGHT headers , e.g.
> test/hotspot/jtreg/runtime/ErrorHandling/NestedThreadsListHandleInErrorHandlingTest.java
Fixed comments as @MBaesken suggested; fixed copyrights. I took the freedom of adding SAP copyrights - with the correct introduction year - for all tests I personally introduces between 2013 and 2019. I had forgotten to do that. Also fixed a bug number that was wrong.
-------------
PR: https://git.openjdk.org/jdk/pull/11283
More information about the hotspot-runtime-dev
mailing list