RFR: 8256302: releasing oopStorage when deflating allows for faster deleting
Daniel D. Daugherty
dcubed at openjdk.org
Tue Nov 29 21:33:31 UTC 2022
On Wed, 23 Nov 2022 00:59:52 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Releasing ObjectMonitor oopStorage earlier when deflating allows ObjectMonitor
>> deletion by a JavaThread (usually the MonitorDeflationThread) to happen while a
>> ThreadBlockInVM helper is in place. This should improve time-to-safepoint.
>
> Seems okay in principal, but some queries on the details.
>
> Thanks.
@dholmes-ora, @robehn, @kimbarrett and @coleenp -
I think I've replied to all the review comments. I haven't updated the code yet
for the things that I said that I would fix, but I'll try to get to that soon.
> src/hotspot/share/runtime/synchronizer.cpp line 1560:
>
>> 1558: }
>> 1559: // Make the calling JavaThread blocked (safepoint safe) while we
>> 1560: // free the ObjectMonitors:
>
> Suggestion s/Make/Mark/
I will fix this.
-------------
PR: https://git.openjdk.org/jdk/pull/11296
More information about the hotspot-runtime-dev
mailing list