RFR: 8291418: adjust monitor deflation logging and deflate_idle_monitors use

Daniel D. Daugherty dcubed at openjdk.org
Tue Nov 29 22:02:44 UTC 2022


On Tue, 22 Nov 2022 23:58:59 GMT, David Holmes <dholmes at openjdk.org> wrote:

> This seems reasonable.

Thanks!

> Just an observation on the pre-existing logic ... it is interesting that logging has a side-effect of deflating idle monitors. If someone was encountering a problem due to too many inflated monitors and turned on logging to try and show them why, the problem might disappear and the logging would be ineffective in aiding in tracking down the problem.

I suppose that is a possibility if, for some reason, the MonitorDeflation thread was not
running in a timely fashion (too long of a delay, missed notification, stuck thread).
However, most cases of too many inflated monitors end up being because the monitors
didn't meet the requirements for being deflated (non-zero waiter count being the most
likely).

-------------

PR: https://git.openjdk.org/jdk/pull/11293


More information about the hotspot-runtime-dev mailing list