RFR: 8282900: runtime/stringtable/StringTableCleaningTest.java verify unavailable at this moment
Robbin Ehn
rehn at openjdk.org
Tue Oct 4 08:46:18 UTC 2022
On Tue, 4 Oct 2022 04:02:02 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Hi, please consider:
>>
>> verify() is called by GC in safepoint so it should use the corresponding scanning method.
>> verify_and_compare_entries() can wait for until there is no resize.
>>
>> This makes these methods always succeed, passes t1-t6.
>
> src/hotspot/share/classfile/stringTable.cpp line 606:
>
>> 604: // This verification is part of Universe::verify() and needs to be quick.
>> 605: void StringTable::verify() {
>> 606: Thread* thr = Thread::current();
>
> You don't need `thr` now
Thanks, fixing!
-------------
PR: https://git.openjdk.org/jdk/pull/10527
More information about the hotspot-runtime-dev
mailing list