RFR: 8294362: UL: Replace the internal usage of manual buffers with stringStream in LogSelection

David Holmes dholmes at openjdk.org
Wed Oct 5 02:04:07 UTC 2022


On Tue, 4 Oct 2022 11:44:26 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> Hi,
> 
> This is only a refactoring where the usage of manual character buffers are replaced with output streams, leading to much simpler code.

This definitely seems simpler and cleaner, but raises the obvious question: why was it not done this way in the first place? Are there initialization issues/constraints with use of the stream classes?

I need to see if there is some historical info on the initial implementation here.

Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/10553


More information about the hotspot-runtime-dev mailing list