RFR: 8294623: gtests does not work with googletest release-1.12.0+

[Dingli Zhang]

On Sat, 8 Oct 2022 07:04:44 GMT, Dingli Zhang <dzhang at openjdk.org> wrote:

>> The scope of `GTEST_DECLARE_string_(internal_run_death_test)` has been changed in googletest 1.12.0 [1]. So we can see some new compiler errors as below:
>> 
>> 
>> $ bash configure --with-gtest=/home/dingli/jdk-tools/googletest && make run-test TEST="gtest:all"
>> 
>> * For target hotspot_variant-server_libjvm_gtest_objs_gtestMain.o:
>> In file included from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/internal/gmock-port.h:57,
>>                  from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/internal/gmock-internal-utils.h:49,
>>                  from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/gmock-actions.h:145,
>>                  from /home/dingli/jdk-tools/googletest/googlemock/include/gmock/gmock.h:56,
>>                  from /home/dingli/jdk/test/hotspot/gtest/unittest.hpp:51,
>>                  from /home/dingli/jdk/test/hotspot/gtest/gtestMain.cpp:39:
>
> @dholmes-ora @tstuefe Hi, could anyone please help to take a look at this PR? Thanks in advance for your time!

> @DingliZhang I've asked if anyone is familiar enough with googletest to review this, as I am not familiar with it.

Hi @dholmes-ora, thank you for your help!

-------------

PR: https://git.openjdk.org/jdk/pull/10503