RFR: 8294772: Remove workaround in os::dll_address_to_library_name

Ioi Lam iklam at openjdk.org
Mon Oct 10 17:29:03 UTC 2022


On Tue, 4 Oct 2022 14:30:58 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

> I ported the BSD implementation of this function. According to the comment this bug should be fixed, as the oldest glibc I can see us supporting is 2.12.x. I've made an attempt at finding the bug that the comment refers to on glibc's bug tracker but has been unsuccesful in this.
> 
> The second commit deletes what seems like an outdated comment (in os_bsd this refers to a code snippet right below the comment).

Looks good except for a nit on the comment.

src/hotspot/os/linux/os_linux.cpp line 1375:

> 1373: }
> 1374: 
> 1375: // Ported from BSD version

I think this comment is not necessary. In fact, the corresponding comment `// ported from solaris version` in os_bsd.cpp should probably be removed as well.

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10559


More information about the hotspot-runtime-dev mailing list