RFR: 8295012: Arena should not derive from CHeapObj<mtNone> [v2]

David Holmes dholmes at openjdk.org
Tue Oct 11 23:54:05 UTC 2022


On Tue, 11 Oct 2022 05:17:40 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Please review this change to the `Arena` class.  Rather than deriving from
>> `CHeapObj<mtNone>` (which has the effect of preventing C-heap allocation for an
>> arena by asserting if such is attempted), instead have no allocation base
>> class so that `new Arena(...)` will fail to compile.
>> 
>> Testing: mach5 tier1
>
> Kim Barrett has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Arena derives from CHeapObjBase

LGTM!

Thanks

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10621


More information about the hotspot-runtime-dev mailing list