RFR: 8295102: Always load @lambda-form-invoker lines from default classlist [v2]
Ioi Lam
iklam at openjdk.org
Wed Oct 12 00:33:06 UTC 2022
On Tue, 11 Oct 2022 23:30:51 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed open/test/hotspot/jtreg:hotspot_appcds_dynamic tests
>
> test/hotspot/jtreg/runtime/cds/appcds/TestCommon.java line 775:
>
>> 773: + ", a=<none>"
>> 774: + ", b=" + b[max]);
>> 775: }
>
> Should these checks be done before the "for" loop at line 756? Otherwise, could one of the array be indexed out-out-bound?
Thanks for finding the bug. I have fixed it in version [2e6af77](https://github.com/openjdk/jdk/pull/10639/commits/2e6af772766dff3432a11b436924185e1b270626). I also tested locally with this code:
String[] a = {"1", "2"}, b = {"1"};
TestCommon.linesMustMatch(a, b);
which correctly produces this error:
java.lang.RuntimeException: Output mismatch on line 1: a=2, b=<none>
-------------
PR: https://git.openjdk.org/jdk/pull/10639
More information about the hotspot-runtime-dev
mailing list