RFR: 8286431: Do not use resource array in posix mmap_attach_shared() [v2]

[Ioi Lam]

On Thu, 13 Oct 2022 06:38:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @dholmes-ora comments
>
> src/hotspot/os/posix/perfMemory_posix.cpp line 1200:
> 
>> 1198:   char* filename = get_sharedmem_filename(dirname, vmid, nspid);
>> 1199: 
>> 1200:   // Handle the exception explicitly so we can free the strings.
> 
> Suggestion:
> // We don't use CHECK as we need to free the strings even if an exception occurred.

Fixed.

> src/hotspot/os/posix/perfMemory_posix.cpp line 1218:
> 
>> 1216:   if (fd == OS_ERR) {
>> 1217:     return;
>> 1218:   }
> 
> I think you still need this for the case where the file is insecure - no exception is thrown in that case.

Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/10686