RFR: 8295029: runtime/cds/appcds/LotsOfClasses.java fail with jfx
Ioi Lam
iklam at openjdk.org
Mon Oct 17 20:35:59 UTC 2022
On Fri, 14 Oct 2022 02:27:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> This removes the can-resize parameter for ClassLoaderData dictionaries. They can all resize now that the shared dictionaries are moved to the CompactHashtable. This also removes an unused/untested development option to disallow resizing.
> Tested with tiers1-4 and tested with the failing test case. It can't be added because it requires outside code or simulated because it would be an expensive test to generate all those class files. There's an existing test for resizing.
LGTM. I agree that if the test is too hard to write (it depends on the exact names of classes being loaded) then we can skip it, because the code change is pretty simple -- it removes a special case for `java -Xshare:dump`. The effect of the removal will be tested by all the tests that dumps a CDS archive.
-------------
Marked as reviewed by iklam (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10708
More information about the hotspot-runtime-dev
mailing list