RFR: 8295029: runtime/cds/appcds/LotsOfClasses.java fail with jfx

Gerard Ziemski gziemski at openjdk.org
Tue Oct 18 19:10:59 UTC 2022


On Fri, 14 Oct 2022 02:27:01 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> This removes the can-resize parameter for ClassLoaderData dictionaries. They can all resize now that the shared dictionaries are moved to the CompactHashtable. This also removes an unused/untested development option to disallow resizing.
> Tested with tiers1-4 and tested with the failing test case. It can't be added because it requires outside code or simulated because it would be an expensive test to generate all those class files.  There's an existing test for resizing.

LGTM

So the only one type of dictionary that gains the super powers of resizing is the DelegatingClassLoader dictionary, but based on comments it's always size 1, so it never will need to be resized?

Related question, but not part of this fix - can we simplify things and not have to bother with 1 element dictionary for DelegatingClassLoader somehow?

-------------

Marked as reviewed by gziemski (Committer).

PR: https://git.openjdk.org/jdk/pull/10708


More information about the hotspot-runtime-dev mailing list