RFR: JDK-8295710 : unify os::dll_file_extension

[David Holmes]

On Thu, 20 Oct 2022 08:12:04 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> The os::dll_file_extension() function could be unified for the different OS platforms.

This looks good but I think we can do better :) There is only a single use of `os::dll_file_extension`:

./share/compiler/disassembler.cpp:  int written = jio_snprintf(&buf[offset], sz, "%s%s", hsdis_library_name, os::dll_file_extension());

so we can remove it altogether and just replace with `JNI_LIB_SUFFIX`.

Thanks.

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10782