RFR: JDK-8295412 : support latest VS2022 MSC_VER in abstract_vm_version.cpp

Magnus Ihse Bursie ihse at openjdk.org
Fri Oct 21 07:25:55 UTC 2022


On Mon, 17 Oct 2022 13:19:48 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

> Currently the latest VS2022 versions are not supported when checking _MSC_VER in abstract_vm_version.cpp, that should be improved.
> See
> https://learn.microsoft.com/en-us/cpp/preprocessor/predefined-macros?view=msvc-170
> https://learn.microsoft.com/de-de/visualstudio/install/visual-studio-build-numbers-and-release-dates?view=vs-2022
> Visual Studio 2022 version 17.3 1933
> Visual Studio 2022 version 17.2 1932

Sorry, I was unclear. Yes, I know it is used for the version string. 

My question was more: I know this has traditionally been included in the version string, but is it *really* needed? What is the use case for having the compiler version? I can fully understand if this is included in a hs_err file, but in that case, maybe the simple "1933" value can suffice, and if the compiler version is suspected to be bad, we can look it up in a table.

-------------

PR: https://git.openjdk.org/jdk/pull/10727


More information about the hotspot-runtime-dev mailing list