RFR: 8295713: runtime/ParallelLoad/SuperWait/SuperWaitTest.java fails intermittently on Windows [v2]

David Holmes dholmes at openjdk.org
Mon Oct 24 00:23:25 UTC 2022


On Fri, 21 Oct 2022 23:10:19 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I added another semaphore so the test will run in the order I want it to.  Alternate suggestions or corrections welcome.
>> Running with GHA, and our tier1 in progress.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Thanks Patricio

Your are doing an unconditional `wait()` which in theory could be affected by a spurious wakeup. If you actually do:

while (!DisLoading) {
  wait();
}

with a corresponding

DisLoading = true;
notify();

then I think you could dispense with the semaphore altogether.

-------------

PR: https://git.openjdk.org/jdk/pull/10822


More information about the hotspot-runtime-dev mailing list