RFR: 8295713: runtime/ParallelLoad/SuperWait/SuperWaitTest.java fails intermittently on Windows [v5]

David Holmes dholmes at openjdk.org
Wed Oct 26 00:33:45 UTC 2022


On Tue, 25 Oct 2022 13:23:38 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I added another semaphore so the test will run in the order I want it to.  Alternate suggestions or corrections welcome.
>> Running with GHA, and our tier1 in progress.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   remove volatile

Okay this seems fine from a logic perspective. There's one nit below that I missed before but up to you whether to change it.
Thanks.

test/hotspot/jtreg/runtime/ParallelLoad/SuperWait/SuperWaitTest.java line 39:

> 37: public class SuperWaitTest {
> 38: 
> 39:     private static boolean dIsLoading = false;

Nit: sorry just noticed the placement here. This is really an instance field of MyLoaderOne.

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10822


More information about the hotspot-runtime-dev mailing list