Integrated: 8293201: Library detection in runtime/ErrorHandling/TestDwarf.java fails on some systems

Aleksey Shipilev shade at openjdk.org
Thu Sep 1 14:18:18 UTC 2022


On Thu, 1 Sep 2022 08:32:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> When building x86_32 on Ubuntu 22.04, the test fails to find the library name in `"C  [libc.so.6+0x85ff1]"`, because the regexp seems too broad. Since we are matching with the unanchored regexp, we can just try and find the smaller prefix, which still matches the library name.
> 
> But the original regexp seems odd to begin with. Why do we match `0x` twice? Why do we have the escaped `\[`, followed by trailing `]` (the last one in the patch now), which is not escaped? This is a question for you, @chhagedorn :)
> 
> Additional testing:
>  - [x] Ubuntu 22.04 x86_32 build

This pull request has now been integrated.

Changeset: 52045282
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/5204528296a53d7dc77e67b26be23a64692527fa
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8293201: Library detection in runtime/ErrorHandling/TestDwarf.java fails on some systems

Reviewed-by: chagedorn

-------------

PR: https://git.openjdk.org/jdk/pull/10113


More information about the hotspot-runtime-dev mailing list