RFR: JDK-8293344: JDK-8242181 broke stack printing for non-attached threads

Christian Hagedorn chagedorn at openjdk.org
Mon Sep 5 11:41:43 UTC 2022


On Mon, 5 Sep 2022 07:12:11 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> https://bugs.openjdk.org/browse/JDK-8242181 gave us source infos in call stacks on Linux, which is really nice, but it made stack printing more vulnerable. We now require Thread::current, which makes stack printing fail and crash in non-attached threads. Causes truncated or missing stacks in hs-err file resp. crashes if stack printing is used outside error reporting.
> 
> I tested the fix manually.
> 
> I also am working on a testing facility for cases like these, which I will introduce in a separate RFE (see https://bugs.openjdk.org/browse/JDK-8293346).

Looks good, thanks for fixing this! I guess I've missed that behind the PPC `ifdef`.

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10158


More information about the hotspot-runtime-dev mailing list