RFR: 8293182: Improve testing of CDS archive heap [v7]
Ioi Lam
iklam at openjdk.org
Wed Sep 7 21:33:37 UTC 2022
On Wed, 7 Sep 2022 17:49:27 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge branch 'master' into 8293182-improve-archive-heap-testing
>> - @coleenp comments
>> - fixed minimal build
>> - Use help message suggedted by @calvinccheung
>> - clarified assert message
>> - @calvinccheung comments
>> - fixed build (gcc spurious warning)
>> - 8293182: Improve testing of CDS archive heap
>
> src/hotspot/share/cds/heapShared.hpp line 298:
>
>> 296:
>> 297: static void resolve_classes_for_subgraphs(ArchivableStaticFieldInfo fields[],
>> 298: JavaThread* THREAD);
>
> Should this be TRAPS or JavaThread* current?
It should be `JavaThread* current`. I'll try to fix that in a separate RFE: https://bugs.openjdk.org/browse/JDK-8293515
-------------
PR: https://git.openjdk.org/jdk/pull/10110
More information about the hotspot-runtime-dev
mailing list