RFR: JDK-8293472: Potentially incorrect container resource limit detection if manual cgroup fs mounts present [v4]

王超 duke at openjdk.org
Thu Sep 8 03:24:39 UTC 2022


On Wed, 7 Sep 2022 09:49:54 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> 王超 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix typo
>
> src/hotspot/os/linux/cgroupSubsystem_linux.cpp line 136:
> 
>> 134:     if (strstr(cg_infos[controller]._mount_path, "/sys/fs/cgroup") != cg_infos[controller]._mount_path) {
>> 135:       log_warning(os, container)("Duplicate %s controllers detected. Picking %s, skipping %s.",
>> 136:                                  name, mount_path, cg_infos[controller]._mount_path);
> 
> Please demote this to `log_debug` over a `log_warning`.

done

> src/hotspot/os/linux/cgroupSubsystem_linux.cpp line 141:
> 
>> 139:     } else {
>> 140:       log_warning(os, container)("Duplicate %s controllers detected. Picking %s, skipping %s.",
>> 141:                                  name, cg_infos[controller]._mount_path, mount_path);
> 
> Please demote this to `log_debug` over `log_warning`.

done

-------------

PR: https://git.openjdk.org/jdk/pull/10193


More information about the hotspot-runtime-dev mailing list