Integrated: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
Man Cao
manc at openjdk.org
Fri Sep 9 19:16:31 UTC 2022
On Sat, 20 Aug 2022 22:43:03 GMT, Man Cao <manc at openjdk.org> wrote:
> Hi all,
>
> Could anyone review this bug fix? See https://bugs.openjdk.org/browse/JDK-8292695 for details.
>
> I changed the temporary handler for SIGQUIT to use a dummy function, and use `os::signal()` to set it up, just as `os::initialize_jdk_signal_support()` does.
> It is possible that just moving the `set_signal_handler(BREAK_SIGNAL, false);` in `install_signal_handlers()` outside of the window bounded by `JVM_{begin|end}_signal_setting()` could also fix this bug. However, `set_signal_handler()` and `JVM_HANDLE_XXX_SIGNAL()` are currently used for signals that support chaining and periodically check, which do not apply to SIGQUIT. I think it is cleaner to use different functions for SIGQUIT.
>
> I also added a test to check that sending SIGQUIT should produce a thread dump on stdout, with and without using libjsig.so.
>
> -Man
This pull request has now been integrated.
Changeset: 45ff10cc
Author: Man Cao <manc at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/45ff10cc68296c7c73d0eafe6fcc9946ab98267e
Stats: 138 lines in 4 files changed: 116 ins; 11 del; 11 mod
8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
Reviewed-by: xliu, stuefe
-------------
PR: https://git.openjdk.org/jdk/pull/9955
More information about the hotspot-runtime-dev
mailing list