RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v4]

Xin Liu xliu at openjdk.org
Sun Sep 11 20:36:40 UTC 2022


On Thu, 8 Sep 2022 11:26:06 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix MSVC warning C4267
>>   
>>   MSVC reports logAsyncWriter.cpp(62): warning C4267: 'initializing': conversion from
>>   'size_t' to 'int', possible loss of data
>
> src/hotspot/share/logging/logAsyncWriter.cpp line 123:
> 
>> 121: 
>> 122:   size_t page_size = os::vm_page_size();
>> 123:   size_t size = align_up(AsyncLogBufferSize / 2, page_size);
> 
> Why page size alignment? Would also interfere with my proposal of testing with a tiny buffer.

I lift this constraint. I thought that it's was wasteful, but the functionality really doesn't depend on the page-alignment.

-------------

PR: https://git.openjdk.org/jdk/pull/10092


More information about the hotspot-runtime-dev mailing list