RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v5]

Thomas Stuefe stuefe at openjdk.org
Mon Sep 12 05:58:04 UTC 2022


On Sun, 11 Sep 2022 05:37:40 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Xin Liu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update per reviewer's feedback.
>>   
>>   Also add a unit test for AsyncLogWriter::Buffer.
>
> src/hotspot/share/logging/logAsyncWriter.hpp line 68:
> 
>> 66: 
>> 67:   // Messsage is the envelop of a log line and its associative data.
>> 68:   // The size is variety-length with zero-terminated c-str. It is only valid when we create it using placement new
> 
> s/variety/variable

Never mind, I see you changed it already

-------------

PR: https://git.openjdk.org/jdk/pull/10092


More information about the hotspot-runtime-dev mailing list