RFR: 8292225: Rename ArchiveBuilder APIs related to source and buffered addresses

[Calvin Cheung]

On Thu, 8 Sep 2022 06:39:56 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> This is a clean up of the source code to make it more readable. 
> - When creating a CDS archive, we first load Java classes and create metadata objects as usual. These are call "source" objects.
> - We then copy the source objects into the output buffer at their "buffered addresses".
> 
> However, we used a mix of other words to refer to them:
> 
> - The word "orig" was also used for the former.
> - The words "dumped" and "relocated" were also used for the latter.
> 
> This PR renamed the names of functions and parameters to consistently use "source" and "buffered" only. In one case I reordered two fields in a class. There's otherwise no change in the code.
> 
> Please see new comments in archiveBuilder.hpp that explains the three types of addresses: "source" vs "buffered" vs "requested".

Renaming seems fine. Were there any tests run with this changset?

-------------

Marked as reviewed by ccheung (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10212