RFR: 8292225: Rename ArchiveBuilder APIs related to source and buffered addresses [v2]

Ioi Lam iklam at openjdk.org
Mon Sep 12 17:32:08 UTC 2022


> This is a clean up of the source code to make it more readable. 
> - When creating a CDS archive, we first load Java classes and create metadata objects as usual. These are call "source" objects.
> - We then copy the source objects into the output buffer at their "buffered addresses".
> 
> However, we used a mix of other words to refer to them:
> 
> - The word "orig" was also used for the former.
> - The words "dumped" and "relocated" were also used for the latter.
> 
> This PR renamed the names of functions and parameters to consistently use "source" and "buffered" only. In one case I reordered two fields in a class. There's otherwise no change in the code.
> 
> Please see new comments in archiveBuilder.hpp that explains the three types of addresses: "source" vs "buffered" vs "requested".

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jdk into 8292225-rename-archive-builder-apis
 - 8292225: Rename ArchiveBuilder APIs related to source and buffered addresses

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/10212/files
  - new: https://git.openjdk.org/jdk/pull/10212/files/dcc4ddd4..7323db4c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=10212&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=10212&range=00-01

  Stats: 12385 lines in 255 files changed: 6939 ins; 4569 del; 877 mod
  Patch: https://git.openjdk.org/jdk/pull/10212.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10212/head:pull/10212

PR: https://git.openjdk.org/jdk/pull/10212


More information about the hotspot-runtime-dev mailing list