RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v8]

Xin Liu xliu at openjdk.org
Tue Sep 13 17:03:42 UTC 2022


On Mon, 12 Sep 2022 14:05:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> HotSpot has a constraint in VMOption. The minimal number is 50K here. 
>> https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/globals.hpp#L1905
>> 
>> I added a unit test in test_asynclog.cpp. Like you said, I feel it's more flexible to write tests if we don't limit size here. 
>> 
>> If buffer capacity is smaller than a token, it will hit assertion in `Buffer::push_flush_token`.
>
> At least add an assert then? Just to show "we know and did not forget" to the casual reader.

updated it!

-------------

PR: https://git.openjdk.org/jdk/pull/10092


More information about the hotspot-runtime-dev mailing list