RFR: JDK-8293472: Incorrect container resource limit detection if manual cgroup fs mounts present [v9]

[Ioi Lam]

On Wed, 14 Sep 2022 01:17:59 GMT, 王超 <duke at openjdk.org> wrote:

>> Similar to [JDK-8253435](https://bugs.openjdk.org/browse/JDK-8253435), when setting the mount path of cgroup controller "memory/cpu/cpuacct/pids", it should also discard duplicate items.
>
> 王超 has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Re-instate the comment

Looks good to me. Just a small nit on the test,

test/hotspot/jtreg/containers/docker/DockerBasicTest.java line 94:

> 92:         DockerTestUtils.dockerRunJava(opts)
> 93:             .shouldHaveExitValue(0)
> 94:             .shouldNotContain("[os,container]");

I think it's worth commenting what you are testing for here. Maybe something like


Duplicated cgroup mounts should be handled by the container detection
code and should not cause any error/warning output.


The `[os,container]` may not match exactly. Some extra spaces may be inserted before the close bracket if longer log tags have been printed. It should be changed to 


shouldNotMatch("[os,container *]");


(Please run the test on a build without your fix to verified that it would indeed fail).

-------------

Marked as reviewed by iklam (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10193