RFR: 8292989: Avoid dynamic memory in AsyncLogWriter [v9]

Xin Liu xliu at openjdk.org
Thu Sep 15 18:36:51 UTC 2022


On Thu, 15 Sep 2022 11:40:54 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>>>IIRC, in hotspot we need two reviews, one Reviewer, the other at least Contributor. Maybe one of your team should propose you as Contributor (@coleenp?), then your reviews count too. I think you have the required number of patches already.
>> 
>> I've heard Reviewer + Author is fine, but I'll get a Contributor to look at this. I think I have the required number of patches, but not all of them are non-trivial so I'm waiting a bit to remove any doubt about the outcome of a vote.
>
>> 
>> > IIRC, in hotspot we need two reviews, one Reviewer, the other at least Contributor. Maybe one of your team should propose you as Contributor (@coleenp?), then your reviews count too. I think you have the required number of patches already.
>> 
>> I've heard Reviewer + Author is fine, but I'll get a Contributor to look at this. I think I have the required number of patches, but not all of them are non-trivial so I'm waiting a bit to remove any doubt about the outcome of a vote.
> 
> Maybe you are right and Author is sufficient for the second vote. Whenever I look for the relevant wiki page I cannot find it :)
> 
> Up to  @navyxliu of course, but since we are not stormed by willing reviewers, I'd just push.

Thanks @tstuefe and @jdksjolen for reviewing this!
--lx

-------------

PR: https://git.openjdk.org/jdk/pull/10092


More information about the hotspot-runtime-dev mailing list