RFR: 8292202: modules_do is called without Module_lock [v2]

Calvin Cheung ccheung at openjdk.org
Thu Sep 15 21:43:53 UTC 2022


On Thu, 15 Sep 2022 18:33:01 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   get rid of the _total_count field
>
> src/hotspot/share/classfile/classLoaderExt.cpp line 99:
> 
>> 97:         char* path_copy = NEW_RESOURCE_ARRAY(char, strlen(path) + 1);
>> 98:         strcpy(path_copy, path);
>> 99:         _module_paths->at_put_grow(_total_count++, path_copy);
> 
> You can use `_module_paths->append()` to avoid keeping the `_total_count`

Fixed.
Thanks for your review.

-------------

PR: https://git.openjdk.org/jdk/pull/10291


More information about the hotspot-runtime-dev mailing list