RFR: 8293851: hs_err should print more stack in hex dump [v2]

Aleksey Shipilev shade at openjdk.org
Fri Sep 16 10:49:45 UTC 2022


On Thu, 15 Sep 2022 13:18:17 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Rename to print_tos
>>  - Drop stack unitsize
>
> I dislike a bit that the new function lives in os.hpp since it is a rather specific function used in one place only and would better live locally in vmError.cpp. 
> 
> I guess it needs to be this way if you want to keep the patch small, because we have no platform-independent API for extracting PC and SP from a context (which would be trivial to implement, but I don't know how far you want to go).

@tstuefe  -- happy with current PR, or?

-------------

PR: https://git.openjdk.org/jdk/pull/10282


More information about the hotspot-runtime-dev mailing list