RFR: JDK-8293493: Signal Handlers printout should show signal block state
David Holmes
dholmes at openjdk.org
Mon Sep 19 02:37:46 UTC 2022
On Wed, 7 Sep 2022 14:51:27 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
> I needed this recently. We print out the signal block mask, which is fine, but more interesting would be the existing block state at the point of the crash/assertion.
This seems okay though may be of limited use if the crash is from a signal as IIRC that in itself will result in various signals getting blocked whilst we remain in the signal-handler context.
Thanks.
src/hotspot/os/posix/signals_posix.cpp line 1418:
> 1416:
> 1417: sigset_t thread_sig_mask;
> 1418: if (::pthread_sigmask(/* ignored */ SIG_BLOCK, NULL, &thread_sig_mask) == 0) {
Nit: no need for `::` scoping (there is one other existing unnecessary use as well you could remove :) ).
-------------
Marked as reviewed by dholmes (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10199
More information about the hotspot-runtime-dev
mailing list