RFR: 8294000: Filler array klass should be in jdk/vm/internal, not in java/vm/internal
Aleksey Shipilev
shade at openjdk.org
Mon Sep 19 12:01:43 UTC 2022
On Mon, 19 Sep 2022 11:24:59 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> can I have reviews for the move of the internal filler array klass from `java/vm/internal/` to `jdk/vm/internal` - I noticed that typo in some recent `jmap` dump. All internal klasses are in the `jdk.` package... idk how this slipped through the original change.
>
> With this change it shows up as
> ` 2: 428 13291728 jdk.internal.vm.FillerArray (java.base at 20-internal)`
> which I believe is best.
>
> Testing: local compilation, checking `jmap` output for instances of this klass directly, the `gc/TestFillerObjectInstantiation.java` jtreg test
>
> Thanks,
> Thomas
I am good with "java" -> "jdk" move, but why are we dropping `L...;`? I would have thought we need to pass the JVM name to `TypeArrayKlass::create_klass`?
-------------
PR: https://git.openjdk.org/jdk/pull/10336
More information about the hotspot-runtime-dev
mailing list